(nuttx-apps) branch master updated: netlib_xarp: remove redundant cast

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new d48b45000 netlib_xarp: remove redundant cast
d48b45000 is described below

commit d48b45000d1d083082f7a1650f351573c36a87d0
Author: zhanghongyu <zhanghon...@xiaomi.com>
AuthorDate: Mon Dec 23 13:42:20 2024 +0800

    netlib_xarp: remove redundant cast
    
    removes redundant type casts in ARP-related network library functions.
    The casts from req.arp_dev (already a char array) to (FAR char *)
    are unnecessary and can be safely removed.
    
    Signed-off-by: zhanghongyu <zhanghon...@xiaomi.com>
---
 netutils/netlib/netlib_delarp.c | 3 +--
 netutils/netlib/netlib_getarp.c | 3 +--
 netutils/netlib/netlib_setarp.c | 3 +--
 nshlib/nsh_netcmds.c            | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/netutils/netlib/netlib_delarp.c b/netutils/netlib/netlib_delarp.c
index 7a263211c..ac8fc1ad6 100644
--- a/netutils/netlib/netlib_delarp.c
+++ b/netutils/netlib/netlib_delarp.c
@@ -76,8 +76,7 @@ int netlib_del_arpmapping(FAR const struct sockaddr_in 
*inaddr,
           memset(&req.arp_ha, 0, sizeof(struct sockaddr_in));
           if (ifname != NULL)
             {
-               strlcpy((FAR char *)&req.arp_dev, ifname,
-                       sizeof(req.arp_dev));
+               strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
             }
           else
             {
diff --git a/netutils/netlib/netlib_getarp.c b/netutils/netlib/netlib_getarp.c
index d023bce30..b98d99f9b 100644
--- a/netutils/netlib/netlib_getarp.c
+++ b/netutils/netlib/netlib_getarp.c
@@ -77,8 +77,7 @@ int netlib_get_arpmapping(FAR const struct sockaddr_in 
*inaddr,
           memcpy(&req.arp_pa, inaddr, sizeof(struct sockaddr_in));
           if (ifname != NULL)
             {
-               strlcpy((FAR char *)&req.arp_dev, ifname,
-                       sizeof(req.arp_dev));
+               strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
             }
           else
             {
diff --git a/netutils/netlib/netlib_setarp.c b/netutils/netlib/netlib_setarp.c
index 1c2261d4c..a62ac9a9e 100644
--- a/netutils/netlib/netlib_setarp.c
+++ b/netutils/netlib/netlib_setarp.c
@@ -81,8 +81,7 @@ int netlib_set_arpmapping(FAR const struct sockaddr_in 
*inaddr,
           req.arp_flags = ATF_PERM;
           if (ifname != NULL)
             {
-               strlcpy((FAR char *)&req.arp_dev, ifname,
-                       sizeof(req.arp_dev));
+               strlcpy(req.arp_dev, ifname, sizeof(req.arp_dev));
             }
           else
             {
diff --git a/nshlib/nsh_netcmds.c b/nshlib/nsh_netcmds.c
index 6010e1084..8cd0d6cc3 100644
--- a/nshlib/nsh_netcmds.c
+++ b/nshlib/nsh_netcmds.c
@@ -1310,7 +1310,7 @@ int cmd_arp(FAR struct nsh_vtbl_s *vtbl, int argc, FAR 
char **argv)
           FAR uint8_t *ptr;
 
           if (ifname != NULL &&
-              strcmp(ifname, (FAR char *)arptab[i].arp_dev) != 0)
+              strcmp(ifname, arptab[i].arp_dev) != 0)
             {
               continue;
             }