arjav1528 commented on PR #3402: URL: https://github.com/apache/nuttx-apps/pull/3402#issuecomment-3890711425
> Question: Wouldn't it be easier to update the URL in the Kconfig file?? > > ``` > config NETUTILS_CJSON_URL > string "URL where cJSON library can be downloaded" > default "https://github.com/DaveGamble/cJSON/archive"; > ``` > > https://github.com/apache/nuttx-apps/blob/master/netutils/cjson/Kconfig Yes, updating the Kconfig default is indeed the cleaner approach, > Hi @arjav1528 please fix > > ``` > ../nuttx/tools/checkpatch.sh -c -u -m -g 7289c27a8509c4943ee359644067b9e9326e93eb..HEAD > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/cjson/CMakeLists.txt > > cmake-format check failed, run following command to update the style: > $ cmake-format <src> -o <dst> > > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx-apps/nuttx-apps/apps/netutils/cjson/CMakeLists.txt > Used config files: > 1: .codespellrc > Some checks failed. For contributing guidelines, see: > https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md > Error: Process completed with exit code 1. > ``` done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
