linguini1 commented on code in PR #18397: URL: https://github.com/apache/nuttx/pull/18397#discussion_r2810009838
########## boards/arm/stm32h7/nucleo-h753zi/src/stm32_lsm6dsl.c: ########## Review Comment: > No. I did not test. But as it was explained this port started from the Linum and this sensor was tested there, right? I would avoid including anything here that you're not able to test. It's not important for the board configuration to support initialization code for the LSM6DSL. We just want the board support, not special device support. It should be up to the user to decide to set up any external peripherals they want to use. This applies to any of the other off-board peripherals you have set-up code for. If you can't test it, don't include it, and if you can test it I still wouldn't recommend including it unless the hardware comes with the board in some kind of kit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
