arjav1528 opened a new pull request, #18400: URL: https://github.com/apache/nuttx/pull/18400
## Summary CMake left `CONFIG_BASE_DEFCONFIG` empty in `.config`, while Make sets it (e.g. `stm32h745i-disco:nsh`). This change updates `cmake/nuttx_mkconfig.cmake` to write the computed value into `.config`: read `.config`, replace or append the `CONFIG_BASE_DEFCONFIG` line, then write it back. Matches Make behavior where `configure.sh` and `Unix.mk` keep this value in `.config`. Fixes [#16695](https://github.com/apache/nuttx/issues/16695). ## Impact - **Users:** CMake `.config` now has `CONFIG_BASE_DEFCONFIG` set (e.g. for `/proc/version` and tooling that reads `.config`). - **Build:** Only CMake config generation is changed; Make and Kconfig unchanged. - **Compatibility:** No change to Make; CMake still uses `board/config` format. ## Testing **Host:** macOS (Darwin, arm64), CMake 4.2.3, Ninja 1.13.2. **Board:** stm32h745i-disco:nsh. - **Before:** Make → `.config` had `CONFIG_BASE_DEFCONFIG="stm32h745i-disco:nsh"`; CMake → `build/.config` had `CONFIG_BASE_DEFCONFIG=""`. - **After:** `cmake -B build -DBOARD_CONFIG=stm32h745i-disco:nsh -GNinja`; `grep CONFIG_BASE_DEFCONFIG build/.config` → `CONFIG_BASE_DEFCONFIG="stm32h745i-disco/nsh-dirty"`. Make path unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
