cederom commented on PR #18410: URL: https://github.com/apache/nuttx/pull/18410#issuecomment-3927316942
> @mzanders: @raiden00pl @cederom Next question is the naming of this new driver. I actually started development with uart_rpmsg_linux, but didn't like the linux in there. What about uart_rpmsg_raw or tty_rpmsg? I would choose most generic name too where possible :-) But if the implementation is platform specific then it having that name may provide a hint to the users so it may be unavoidable ;-) You are the author so you have the choice.. if this will align with existing `uart_rpmsg.c` then probably `uart_rpmsg_something.c` would seems most suitable :-) Quick search: * FreeBSD seems to use VirtIO abstraction (https://github.com/search?q=repo%3Afreebsd%2Ffreebsd-src%20rpmsg&type=code). * OpenAMP seems to use VirtIO abstraction too (https://openamp.readthedocs.io/en/latest/protocol_details/rpmsg.html). * STM seems to use `uart_rpmsg_bus` (https://github.com/meremST/uart_rpmsg_bus/blob/master/uart_rpmsg_bus.c). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
