linguini1 commented on code in PR #3405: URL: https://github.com/apache/nuttx-apps/pull/3405#discussion_r2838299905
########## system/sensorscope/sensorscope_main.c: ########## @@ -411,16 +411,10 @@ int main(int argc, FAR char *argv[]) pthread_t thread; int ret; -#ifndef CONFIG_NSH_ARCHINIT - /* Perform architecture-specific initialization (if configured) */ - - boardctl(BOARDIOC_INIT, 0); - -# ifdef CONFIG_BOARDCTL_FINALINIT +#if defined(CONFIG_BOARDCTL_FINALINIT) && !defined(CONFIG_BOARD_LATE_INITIALIZE) Review Comment: I suppose my idea here was the use-case raiden mentioned, where users that still want control over the init process put a custom one in `board_finalinitialize`. But, I guess in that case they should be allowed to enable both options anyways. I will modify this (and anywhere else I did this) to just check for `CONFIG_BOARD_FINALINIT`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
