masc2008 commented on code in PR #3404: URL: https://github.com/apache/nuttx-apps/pull/3404#discussion_r2844499356
########## include/netutils/icmpv6_ping.h: ########## @@ -66,53 +66,8 @@ * Public Types ****************************************************************************/ -struct ping6_result_s; - -struct ping6_info_s Review Comment: The purpose is to let ping_result_s and ping6_result_s share same data structure. since in the callback same pointer was transferred, they will be used in different callback. same reason to ping_info_s and ping6_info_s. if they have have private structure, and changed privately, then it will have very high risk, not easy to maintain them. considering this, should let them share same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
