xiaoxiang781216 commented on code in PR #17991:
URL: https://github.com/apache/nuttx/pull/17991#discussion_r2850765926
##########
fs/Kconfig:
##########
@@ -46,6 +46,7 @@ config FS_AUTOMOUNTER_DRIVER
bool "Auto-mounter driver"
default n
depends on FS_AUTOMOUNTER
+ depends on !DISABLE_ALL_SIGNALS
Review Comment:
merge to line 48
##########
libs/libc/unistd/lib_sleep.c:
##########
@@ -109,7 +110,11 @@ unsigned int sleep(unsigned int seconds)
rqtp.tv_sec = seconds;
rqtp.tv_nsec = 0;
+#ifdef CONFIG_DISABLE_ALL_SIGNALS
+ ret = nxsched_nanosleep(&rqtp, &rmtp);
+#else
ret = clock_nanosleep(CLOCK_REALTIME, 0, &rqtp, &rmtp);
Review Comment:
let's modify clock_nanosleep instead since nxsched_nanosleep can't be called
from userspace
##########
libs/libc/unistd/lib_usleep.c:
##########
@@ -108,7 +109,11 @@ int usleep(useconds_t usec)
rqtp.tv_sec = sec;
rqtp.tv_nsec = (usec - (sec * USEC_PER_SEC)) * NSEC_PER_USEC;
+#ifdef CONFIG_DISABLE_ALL_SIGNALS
+ ret = nxsched_nanosleep(&rqtp, NULL);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
