simbit18 commented on PR #18493:
URL: https://github.com/apache/nuttx/pull/18493#issuecomment-4005868897
> > > > > @linguini1 we commented at #17447 I agreed that he could modify
the Kconfig without testing in real hardware, because I already tested it. BTW,
I can retest here to have peace of mind
> > > >
> > > >
> > > > Could you please restart the workflows, seems like a timeout error
> > >
> > >
> > > @arjav1528 actually it is not timeout error. Since you changed the
default values in the Kconfig some boards using this driver need to be updated
(normalized), please use this command for each board and profile listed in the
error:
> > > ```
> > > ./tools/refresh.sh --silent boardname:profilename
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ie
> > > ```
> > > ./tools/refresh.sh --silent esp32-devkitc:bmp280
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > Then create a commit with the updated board profiles
> >
> >
> > @acassis I guess this is a timeout issue only as I ran the commands
which you suggested on every board profile that uses SX127X drivers. All of
them existed with code 0, and neither of them produced any deconfig changes
could you please check the CI logs and try restarting the workflows. btw
attached the logs in the PR desc
>
> @arjav1528 please look the logs, there are real errors:
>
> ```
> board/esp32_bringup.c: In function 'esp32_bringup':
> Error: board/esp32_bringup.c:351:9: error: implicit declaration of
function 'btn_lower_initialize'; did you mean 'nullmtd_initialize'?
[-Wimplicit-function-declaration]
> 351 | ret = btn_lower_initialize("/dev/buttons");
> | ^~~~~~~~~~~~~~~~~~~~
> | nullmtd_initialize
> make[1]: *** [/github/workspace/sources/nuttx/boards/Board.mk:83:
esp32_bringup.o] Error 1
> make[1]: Target 'libboard.a' not remade because of errors.
> make: *** [tools/LibTargets.mk:89: arch/xtensa/src/board/libboard.a] Error
2
> make: Target 'all' not remade because of errors.
> /github/workspace/sources/nuttx/tools/testbuild.sh: line 385:
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or
directory
> [1/1] Normalize esp32-wrover-kit/buttons
> 19d18
> < CONFIG_ARCH_IRQBUTTONS=y
> 35d33
> < CONFIG_INPUT_BUTTONS_LOWER=y
> Saving the new configuration file
> HEAD detached at pull/18493/merge
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git restore <file>..." to discard changes in working directory)
> modified: boards/xtensa/esp32/esp32-devkitc/configs/bmp280/defconfig
> modified: boards/xtensa/esp32/esp32-devkitc/configs/buttons/defconfig
> modified:
boards/xtensa/esp32/esp32-ethernet-kit/configs/buttons/defconfig
> modified: boards/xtensa/esp32/esp32-lyrat/configs/buttons/defconfig
> modified:
boards/xtensa/esp32/esp32-wrover-kit/configs/buttons/defconfig
> modified: boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig
> ```
>
> Maybe it was generated by some other user, please move to upstream branch,
run git pull, move back to your branch and rebase with upstream to see if it
will help.
>
> @simbit18 did you see this error in the mainline?
@arjav1528 please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
