neilberkman opened a new pull request, #3419:
URL: https://github.com/apache/nuttx-apps/pull/3419

   ## Summary
   
   Fix two Clang `-Werror` failures when building nxboot with 
`CONFIG_ARM_TOOLCHAIN_CLANG`:
   
   - `loader/flash.c`: use `PRIdOFF` instead of `%ld` for `off_t` arguments in 
syslog calls, fixing `-Wformat` when `off_t` is not `long`.
   - `nxboot_main.c` / `nxboot.h`: change `nxboot_progress` parameter from 
`enum progress_type_e` to `int` to avoid undefined behavior from `va_start` on 
a parameter that undergoes default argument promotion (`-Wvarargs`).
   
   ## Impact
   
   Fixes build failures for any board config that enables nxboot with Clang 
(e.g. nucleo-h743zi/nxboot-loader, nucleo-h743zi/nxboot-app in 
apache/nuttx#18509).
   
   ## Testing
   
   Build: nucleo-h743zi/nxboot-loader and nucleo-h743zi/nxboot-app with 
`CONFIG_ARM_TOOLCHAIN_CLANG`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to