JianyuWang0623 opened a new pull request, #3425:
URL: https://github.com/apache/nuttx-apps/pull/3425
## Summary
Fix two issues in `examples/camera`:
1. **Build error**: camera_bkgd.c calls `boardctl(BOARDIOC_NX_START, 0)` but
is missing `#include <sys/boardctl.h>`, causing:
- `implicit declaration of function 'boardctl'`
- `'BOARDIOC_NX_START' undeclared`
2. **Logic fix**: camera_main.c unconditionally enters still-capture frame
size enumeration (`VIDIOC_ENUM_FRAMESIZES` for `V4L2_BUF_TYPE_STILL_CAPTURE`)
even when the user requested video capture. Added `capture_type ==
V4L2_BUF_TYPE_STILL_CAPTURE` guard so the still-specific path is only taken
when appropriate.
## Impact
- Fixes build failure when `CONFIG_EXAMPLES_CAMERA_OUTPUT_LCD=y` (NX backend
path).
- Corrects runtime behavior: video capture mode no longer attempts
still-capture frame size enumeration.
- No API or configuration changes.
## Testing
Build verified with `lckfb-szpi-esp32s3/camera` config (ESP32-S3, GC0308 DVP
camera + ST7789 LCD):
- Host: Ubuntu x86_64, GCC (xtensa-esp32s3-elf)
- Target: `xtensa`, `lckfb-szpi-esp32s3:camera`
- Build: `make -j8` — passes without errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
