Abhishekmishra2808 commented on code in PR #18396:
URL: https://github.com/apache/nuttx/pull/18396#discussion_r2984052040
##########
cmake/nuttx_add_romfs.cmake:
##########
@@ -282,6 +282,83 @@ function(process_all_directory_romfs)
list(PREPEND RCSRCS ${board_rcsrcs} ${dyn_rcsrcs})
list(PREPEND RCRAWS ${board_rcraws} ${dyn_rcraws})
+ # Auto-generate /etc/passwd at build time if configured
+ if(CONFIG_BOARD_ETC_ROMFS_PASSWD_ENABLE)
+ if("${CONFIG_BOARD_ETC_ROMFS_PASSWD_PASSWORD}" STREQUAL "")
Review Comment:
Same approach here as Make path: no duplicated detailed checks, only one
early empty-password check for fail-fast feedback and leave full validation to
mkpasswd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]