Sumit6307 commented on PR #18607: URL: https://github.com/apache/nuttx/pull/18607#issuecomment-4132094917
@xiaoxiang781216 Thank you for the detailed review! I have addressed all the inline feedback: - Removed the unrelated `mnemofs` commit by rebasing onto master. - Pushed all internal `#ifdef` macros directly into [fs/vfs/vfs.h](cci:7://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/fs/vfs/vfs.h:0:0-0:0) and removed [fs_profile.h](cci:7://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/include/nuttx/fs/fs_profile.h:0:0-0:0). - Switched to `perf_gettime()` and [atomic_fetch_add](cci:1://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/include/nuttx/atomic.h:240:0-241:44) for zero-overhead, lockless SMP thread safety. - Used `procfs_snprintf` and updated the [Kconfig](cci:7://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/fs/procfs/Kconfig:0:0-0:0) as requested by @acassis and @cederom. - Added a [profiler.rst](cci:7://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/Documentation/components/filesystem/profiler.rst:0:0-0:0) documentation file. Regarding **`sched_note`**: While `sched_note` is fantastic for deep, host-side system tracing, it is somewhat heavyweight for simple regression tests. The goal of this specific VFS Profiler is to provide **immediate, always-on, aggregated statistics** (total call counts and total elapsed nanoseconds/ticks) directly on the target device. By exposing this purely through `/proc/fs/profile`, automated CI test scripts (or users in NSH) can simply run `cat /proc/fs/profile` before and after a filesystem workload to instantly calculate throughput and regressions, without needing to dump, decode, and aggregate transient `sched_note` binary traces on a host machine. This makes automated on-target benchmarking vastly simpler. The CI checks (both `check` and `build-html`) should now be strictly passing. Let me know if there's anything else needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
