HongChao6 commented on PR #3434: URL: https://github.com/apache/nuttx-apps/pull/3434#issuecomment-4166917542
@linguini1 Thanks for the review @linguini1! I agree with the GETEVENT_ERR macro and printf for show_usage — those changes make sense and I'll apply them. Regarding GETEVENT_INFO and LOG_INFO: since getevent is an interactive command-line tool where the event data output is directly requested by the user, I'm wondering if printf (stdout) would be a better fit here as well, rather than syslog at any level. My reasoning: Event data is user-facing output, not system log messages Using printf avoids dependency on CONFIG_SYSLOG_LEVEL — with LOG_INFO, output could be silently filtered on systems with a higher default syslog threshold This is consistent with how Android's getevent works (stdout) syslog would still be used for actual errors via GETEVENT_ERR What do you think? Happy to go with LOG_INFO if you prefer keeping syslog for everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
