acassis commented on PR #18715: URL: https://github.com/apache/nuttx/pull/18715#issuecomment-4231366525
@Abhishek-2808 some suggestions: Improve the error message to help the user to find where to fix the password: Run 'make menuconfig' and select a password at: Board Selection ---> Auto-generate /etc/passwd at build time ---> Admin password This PR is a breaking change, so, please include "!" before the titles of your commit title and include a Breaking Changes in the commit message, read https://nuttx.apache.org/docs/latest/contributing/guide.html for more info about it. Since NuttX is a POSIX and Unix-like system, I think it make more sense to use the "root" username instead of "admin". So change the saved username from "admin" to "root" (you can keep the Admin name in the menuconfig. @linguini1 @cederom do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
