xiaoxiang781216 commented on code in PR #3404:
URL: https://github.com/apache/nuttx-apps/pull/3404#discussion_r3070570141


##########
system/ping/ping.c:
##########
@@ -279,6 +290,60 @@ static void ping_result(FAR const struct ping_result_s 
*result)
     }
 }
 
+#ifdef PING_ENABLE_PING6_FALLBACK
+/****************************************************************************
+ * Name: ping6_fallback
+ ****************************************************************************/
+
+static int ping6_fallback(int argc, FAR char *argv[])
+{
+  FAR char **child_argv;
+  pid_t pid;
+  int ret;
+  int status;
+  int i;
+
+  child_argv = malloc(sizeof(FAR char *) * (argc + 1));

Review Comment:
   remove malloc, let's modify argv[0] directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to