xiaoxiang781216 commented on code in PR #18607: URL: https://github.com/apache/nuttx/pull/18607#discussion_r3071607084
########## fs/vfs/fs_profile.c: ########## Review Comment: remove all casts ########## fs/vfs/vfs.h: ########## Review Comment: atomic64_t ########## fs/procfs/fs_procfsprofile.c: ########## Review Comment: atomic64_read ########## fs/procfs/fs_procfs.c: ########## Review Comment: ```suggestion extern const struct procfs_operations g_fsprofile_operations; ``` ########## fs/procfs/fs_procfsprofile.c: ########## Review Comment: remove the check ########## fs/vfs/fs_profile.c: ########## Review Comment: add blank line ########## fs/procfs/fs_procfsprofile.c: ########## Review Comment: need atomic_read ########## fs/vfs/vfs.h: ########## Review Comment: change ALL vfs_/VFS_ to fs_/FS_ ########## fs/vfs/vfs.h: ########## Review Comment: atomic_t -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
