xiaoxiang781216 commented on code in PR #3451:
URL: https://github.com/apache/nuttx-apps/pull/3451#discussion_r3076732350
##########
netutils/netlib/netlib_obtainipv4addr.c:
##########
@@ -156,6 +214,18 @@ static int dhcp_obtain_statefuladdr(FAR const char *ifname)
if (ret == OK)
{
ret = dhcp_setup_result(ifname, &ds);
+#ifdef CONFIG_NETUTILS_NTPCLIENT
+ if (ret == OK)
+ {
+ ret = dhcp_set_ntp_servers(&ds);
Review Comment:
the major difference is that:
1. buitlin apps(CONFIG_xxx=y) is bundled in to nuttx.bin and just has one
set of global variables shared by all executed instance
2. elf apps(CONFIG_xxx=m) is a seperated elf file keep in external
storage(file system, or hostfs on sim), each executed instance contain unique
global variables like the tranditional Unix application
So, to improve the compatibility, the major action is avoid sharing info
between apps through global variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
