simbit18 commented on code in PR #18730: URL: https://github.com/apache/nuttx/pull/18730#discussion_r3078285292
########## boards/xtensa/esp32s3/esp32s3-ws-lcd128/Kconfig: ########## @@ -0,0 +1,38 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +if ARCH_BOARD_ESP32S3_WS_LCD128 + +choice + prompt "BOARD VARIANT" + default ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH + help + There are two variants of the board with [1] and without [2] touch screen. + These boards also have slightly different signals and capabilities. + Non-touch variant has two connectors with many more GPIO available. + + [1] https://www.waveshare.com/esp32-s3-touch-lcd-1.28.htm + [2] https://www.waveshare.com/esp32-s3-lcd-1.28.htm + + NOTE: Touch screen driver is not yet implemented! + +config ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH + bool "NO-TOUCH ESP32-S3-LCD-1.28" + select LCD + help + Mark this choice if your board has no touch screen module installed. + www.waveshare.com/esp32-s3-lcd-1.28.htm + +config ARCH_BOARD_ESP32S3_WS_LCD128_TOUCH + bool "TOUCH ESP32-S3-Touch-LCD-1.28" + help + Mark this choice if your board has touch screen module installed. + www.waveshare.com/esp32-s3-touch-lcd-1.28.htm + + NOTE: Touch screen driver is not yet implemented! + +endchoice + Review Comment: Hi @cederom , please correct the style of the Kconfig files. - add TAB - help -> ---help--- ########## boards/xtensa/esp32s3/esp32s3-ws-lcd128/Kconfig: ########## @@ -0,0 +1,38 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +if ARCH_BOARD_ESP32S3_WS_LCD128 + +choice + prompt "BOARD VARIANT" + default ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH + help + There are two variants of the board with [1] and without [2] touch screen. + These boards also have slightly different signals and capabilities. + Non-touch variant has two connectors with many more GPIO available. + + [1] https://www.waveshare.com/esp32-s3-touch-lcd-1.28.htm + [2] https://www.waveshare.com/esp32-s3-lcd-1.28.htm + + NOTE: Touch screen driver is not yet implemented! + +config ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH + bool "NO-TOUCH ESP32-S3-LCD-1.28" + select LCD + help + Mark this choice if your board has no touch screen module installed. + www.waveshare.com/esp32-s3-lcd-1.28.htm + +config ARCH_BOARD_ESP32S3_WS_LCD128_TOUCH + bool "TOUCH ESP32-S3-Touch-LCD-1.28" + help + Mark this choice if your board has touch screen module installed. + www.waveshare.com/esp32-s3-touch-lcd-1.28.htm + + NOTE: Touch screen driver is not yet implemented! + +endchoice Review Comment: Hi @cederom , please correct the style of the Kconfig files. - add TAB - help -> ---help--- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
