acassis commented on code in PR #18738:
URL: https://github.com/apache/nuttx/pull/18738#discussion_r3086223338
##########
net/ipforward/ipv4_forward.c:
##########
@@ -634,6 +634,18 @@ void ipv4_forward_broadcast(FAR struct net_driver_s *dev,
return;
}
+ /* Do not forward link-local multicast packets (224.0.0.0/24).
+ * Per RFC 3171, addresses in 224.0.0.0/24 are reserved for
+ * link-local scope and MUST NOT be forwarded by any router,
+ * regardless of TTL.
+ */
+
+ if ((net_ip4addr_conv32(ipv4->destipaddr) &
+ HTONL(0xffffff00)) == HTONL(0xe0000000))
+ {
+ return;
Review Comment:
Maybe it could be interesting to report a network debug warning here, or, do
you think it is not necessary? If not, why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
