simbit18 commented on PR #18744: URL: https://github.com/apache/nuttx/pull/18744#issuecomment-4267237945
Hi @acassis, I hope to explain below why we came up with this new system https://github.com/apache/nuttx/issues/18568 and why I advised you to take a test. - **apache/nuttX** repository with your PR #18744 Nuttx repository: acassis/incubator-nuttx Nuttx branch: fix_modbus_loc Apps repository: **apache/nuttx-apps** Apps branch: **master** Host platform: Linux, MSYS2 and MSVC **Tests on all boards** The NuttX source code here includes the changes made to defconfig The Apps source code here does not include the change to the path for industry/modbus - **apache/nuttx-apps** repository with your PR #3457 Nuttx repository: **apache/nuttx** Nuttx branch: **master** Apps repository: acassis/nuttx-apps Apps branch: master Host platform: Linux, MSYS2 and MSVC **Tests on all boards** The NuttX source here does **not includes defconfig changes" The Apps source here include the change to the path for industry/modbus - **manual-nuttx-ci** with both PRs PR #18744 PR https://github.com/apache/nuttx-apps/pull/3457 Nuttx repository: acassis/incubator-nuttx Nuttx branch: fix_modbus_loc Apps repository: acassis/nuttx-apps Apps branch: master Host platform: **Linux, MSYS2, macOS and MSVC** **Tests on all boards** The NuttX source code here includes the changes made to defconfig The Apps source here include the change to the path for industry/modbus When a change affects the PRs in both repositories, it is very difficult for NuttX maintainers to check whether those changes might cause problems after merging. This new system helps us to verify that the build at least doesn’t break anything. Results of the test I carried out error here ``` ==================================================================================== Configuration/Tool: linum-stm32h753bi/modbus_master,CONFIG_ARM_TOOLCHAIN_CLANG 2026-04-17 10:03:44 ------------------------------------------------------------------------------------ Cleaning... Configuring... Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI Enabling CONFIG_ARM_TOOLCHAIN_CLANG Building NuttX... ld.lld: error: undefined symbol: eMBMasterReqReadHoldingRegister >>> referenced by mbmaster_main.c:312 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:312) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_main) in archive /github/workspace/sources/nuttx/staging/libapps.a ld.lld: error: undefined symbol: eMBMasterInit >>> referenced by mbmaster_main.c:138 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:138) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_initialize) in archive /github/workspace/sources/nuttx/staging/libapps.a ld.lld: error: undefined symbol: eMBMasterEnable >>> referenced by mbmaster_main.c:149 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:149) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_initialize) in archive /github/workspace/sources/nuttx/staging/libapps.a ld.lld: error: undefined symbol: eMBMasterPoll >>> referenced by mbmaster_main.c:195 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:195) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_pollthread) in archive /github/workspace/sources/nuttx/staging/libapps.a ld.lld: error: undefined symbol: eMBMasterDisable >>> referenced by mbmaster_main.c:172 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:172) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_deinitialize) in archive /github/workspace/sources/nuttx/staging/libapps.a ld.lld: error: undefined symbol: eMBMasterClose >>> referenced by mbmaster_main.c:176 (/github/workspace/sources/apps/examples/modbusmaster/mbmaster_main.c:176) >>> mbmaster_main.c.github.workspace.sources.apps.examples.modbusmaster_1.o:(mbmaster_deinitialize) in archive /github/workspace/sources/nuttx/staging/libapps.a make[1]: *** [Makefile:226: nuttx] Error 1 make: *** [tools/Unix.mk:568: nuttx] Error 2 make: Target 'all' not remade because of errors. /github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory [1/1] Normalize linum-stm32h753bi/modbus_master On branch fix_modbus_loc Your branch is up to date with 'origin/fix_modbus_loc'. Untracked files: (use "git add <file>..." to include in what will be committed) boards/arm/stm32h7/linum-stm32h753bi/scripts/flash.ld.tmp nothing added to commit but untracked files present (use "git add" to track) ==================================================================================== ``` [Linux (arm-13)](https://github.com/simbit18/manual-nuttx-ci/actions/runs/24523935870/job/71792253168#logs) https://github.com/simbit18/manual-nuttx-ci/actions/runs/24523935870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
