cederom commented on PR #18730: URL: https://github.com/apache/nuttx/pull/18730#issuecomment-4301344871
@fdcavalcanti I have double checked, please take a look and let me know what you think, if you see another choice please suggest the implementation :-) * `touch-lvgl` contians unnecessary leftovers and I will adjust it to `notouch-lvgl` that will contain smaller debug features that similar boards? I missed that thanks! :-) * `nsh` contains extra `CONFIG_DEBUG_FEATURES` compated to `esp32s3-devkit:nsh` and should be removed? * `ostest` contains extra `CONFIG_DEBUG_FEATURES` compated to `esp32s3-devkit:ostest` and should be removed? | ESP32S3-WS-LCD128 config | similar config | debug features | |---|---|---| | coremark | esp32s3-devkit:coremark | the same | | imu-qmi8658 | lckfb-szpi-esp32s3:qmi8658 | the same | | notouch-lvgl | esp32s3-box:lvgl | smaller | | notouch-lvgl | lckfb-szpi-esp32s3:lvgl | smaller | | nsh | esp32s3-devkit:nsh | extra `CONFIG_DEBUG_FEATURES` | | ostest | esp32s3-devkit:ostest | extra `CONFIG_DEBUG_FEATURES` | | touch-lvgl | notouch-lvgl | extra `CONFIG_DEBUG_ASSERTIONS`, `CONFIG_DEBUG_ASSERTIONS_EXPRESSION`, `CONFIG_DEBUG_FEATURES`, `CONFIG_NDEBUG` to be removed and aligned with `notouch-lvgl`! | ``` % grep -r CONFIG_NDEBUG * coremark/defconfig:# CONFIG_NDEBUG is not set touch-lvgl/defconfig:CONFIG_NDEBUG=y % grep -r CONFIG_DEBUG_FEATURES * nsh/defconfig:CONFIG_DEBUG_FEATURES=y ostest/defconfig:CONFIG_DEBUG_FEATURES=y touch-lvgl/defconfig:CONFIG_DEBUG_FEATURES=y ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
