simbit18 commented on PR #18780:
URL: https://github.com/apache/nuttx/pull/18780#issuecomment-4303129653

   Hi @acassis , please align CMake with Make
   
   ```
   if(CONFIG_INPUT_MPR121_KEYPAD)
     list(APPEND SRCS stm32_mpr121.c)
   endif()
   ```
   
   
https://github.com/acassis/incubator-nuttx/blob/9572f36a63ce9471fba2bc87306d8877a5f91da8/boards/arm/stm32/common/src/CMakeLists.txt#L84
   
   
   We also have a simple verification workflow  
https://github.com/apache/nuttx/issues/18568 for these tasks; all you need to 
do is provide `board:config` (build for Make and CMake)
   
   
   Set it up as follows:
   
   ```
   Nuttx repository: acassis/incubator-nuttx
       Nuttx branch: keypad_mpr121
    Apps repository: apache/nuttx-apps
        Apps branch: master
             Config: stm32f4discovery:mpr121_keypad
       Build system: all
   ```
   Workflow -> Manually Compiling with Make or Cmake for test
   
   
   Why don’t we use our free GitHub for simple validation tests? :)
   
   
   That’s why I recommend everyone uses this 
https://github.com/apache/nuttx/issues/18568 tool : 
   - it uses our Nuttx Docker image 
   - it helps run tests in advance before creating a PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to