tmedicci commented on PR #3461: URL: https://github.com/apache/nuttx-apps/pull/3461#issuecomment-4304464805
Hi @cederom ! > Would it be possible to mark this change as breaking with a short note that `rmtchar` is removed and replaced by `irtest`? I updated PR's description (and the respective commit) with the following message: ``` The upper-half RMT driver is no longer available on NuttX. Instead, Espressif's RMT peripheral was bound directly to the lirc driver. For testing purposes, use the irtest application. ``` I also added the `breaking change` tag, but it isn't really a breaking change because it just removed a deprecated application. The "breaking change" was introduced by https://github.com/apache/nuttx/pull/18654 ``` NuttX OS PR https://github.com/apache/nuttx/pull/18654 removed the upper-half driver interface used by this application, so removing it does not break any existing feature on NuttX. ``` > We also need documentation update there are references to `rmtchar` see https://nuttx.apache.org/docs/latest/search.html?q=rmtchar&check_keywords=yes&area=default :-) I'll prepare a PR for updating on NuttX OS repo, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
