ldube opened a new pull request, #18830: URL: https://github.com/apache/nuttx/pull/18830
This commit fixes a regression introduced by 89df084b0e51593643ccc2f6427ac11c99243295. That commit added a check to ensure iov_base is not NULL, assuming NULL always represents an inaccessible address. However, in CONFIG_BUILD_KERNEL mode where CONFIG_ARCH_TEXT_VBASE is set to 0, address zero is a valid virtual address for the user-space text segment. The previous check caused libelf to fail with -EFAULT when attempting to load ELF program headers into the base of the user address space. This patch wraps the safety check in a conditional to ensure it is only executed when address zero is not considered a valid executable base. *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary *Update this section with information on why change is necessary, what it exactly does and how, if new feature shows up, provide references (dependencies, similar problems and solutions), etc.* ## Impact *Update this section, where applicable, on how change affects users, build process, hardware, documentation, security, compatibility, etc.* ## Testing *This section should provide a detailed description of what you did to verify your changes work and do not break existing code.* *Please provide information about your host machine, the board(s) you tested your changes on, and how you tested. Logs should be included.* *For example, when changing something in the core OS functions, you may want to run the OSTest application to verify that there are no regressions. Changes to ADC code may warrant running the `adc` example. Adding a new uORB driver may require that you run `uorb_listener` to verify correct operation.* *Pure documentation changes can just be tested with `make html` (see docs) and verification of the correct format in your browser.* **_PRs without testing information will not be accepted. We will request test logs._** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
