cederom commented on PR #18879: URL: https://github.com/apache/nuttx/pull/18879#issuecomment-4450445881
> Hi @cederom , thanks for submitting it! > > Just a suggestion: about [www.waveshare.com/wiki/ESP32-P4-NANO](http://www.waveshare.com/wiki/ESP32-P4-NANO), wouldn't it be better to create a specific board entry for it (and corresponding defconfigs) in the future? > > For now, it's fine, and we can eventually use the same from ESP32-P4-Function-EV-Board. Yes @tmedicci initially I even started creating board definition, and wanted it to be part of my test setup, but two things stopped me: 1. It has almost very similar schematics with function board, thus nsh, ostest, eth should work, so I only put note it is somewhat compatible. 2. It has ESP32-P4 v1.3 that it not compatible with v3 thus I am not sure if there is a reason behind supporting such board? Looks like it can be a mine field :-P If you think they may replace chip revision one day (I will ask WS today) and that board still should be added then I will add it no problem please let me know :-) And BIG THANK YOU for adding backward compatibility for older chips @tmedicci !! Looks like additional lots of work :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
