raiden00pl commented on PR #3477: URL: https://github.com/apache/nuttx-apps/pull/3477#issuecomment-4453109048
> What is your problem and solution here @raiden00pl ? Why not include tar.gz ? 1. this approach is not used anywhere in nuttx repos. Source in tar.gz is harder to maintain and most likely doesn't work well with git diff. 2. you still include source code to nuttx repo (packing it in an archive doesn't change anything here), so for me this is nothing else like a low-effort workaround for nxstyle. What are solution: 1. copy-paste files but fix all nxstyle issues so the code meets nuttx standards, 2. fetch from external repo like it's done for all other external packages. I don't know if `rtttl-c` project will be developed further or if this is its final form. At the moment for such a simple code, the correct approach is 1. If I understand correctly the author of the PR is also the author of the lib (I haven't seen the lib repo before, so I didn't know), so this is no problem from licence point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
