PiyushPatle26 commented on code in PR #18907:
URL: https://github.com/apache/nuttx/pull/18907#discussion_r3293820553
##########
drivers/serial/uart_16550.c:
##########
@@ -807,11 +807,6 @@ static int u16550_setup(FAR struct uart_dev_s *dev)
return -EPERM;
}
- /* Clear fifos */
Review Comment:
The issue was AM62x-specific bring-up rather than a generic 16550 functional
bug. The AM62x UART required the FIFO setup to be programmed as separate
writes, so the old standalone ‘Clear fifos’ comment no longer matched the
actual sequence. I added a comment beside the new FIFO configuration block to
explain why the setup is done that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
