patrickelectric commented on code in PR #18950:
URL: https://github.com/apache/nuttx/pull/18950#discussion_r3295912527
##########
libs/libc/machine/arm/armv8-m/Kconfig:
##########
@@ -7,7 +7,7 @@ if ARCH_ARMV8M
config ARMV8M_STRING_FUNCTION
bool "Enable optimized ARMv8M specific string function"
- default n
+ default y
Review Comment:
It adds 1.2kB in flash. (at least from the test that I did here)
I would believe that small chips could just disable this option, and so
having it on by default. This has a terrible performance impact as showed in
the commit body and PR body as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
