xiaoxiang781216 commented on code in PR #18962: URL: https://github.com/apache/nuttx/pull/18962#discussion_r3302367861
########## sched/clock/clock_gettime.c: ########## @@ -215,7 +215,7 @@ int nxclock_gettime(clockid_t clock_id, FAR struct timespec *tp) * ****************************************************************************/ -int clock_gettime(clockid_t clock_id, FAR struct timespec *tp) +int weak_function clock_gettime(clockid_t clock_id, FAR struct timespec *tp) Review Comment: it's wrong to expose the host clock_gettime to nuttx. We should use the same approach as Linux, which do the conversion in arch/sim/posix. what's problem do you hit on macOS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
