toku-mac commented on code in PR #3510:
URL: https://github.com/apache/nuttx-apps/pull/3510#discussion_r3322558993
##########
tools/aarch64-unknown-nuttx-macho.json:
##########
@@ -0,0 +1,35 @@
+{
+ "arch": "aarch64",
+ "archive-format": "darwin",
+ "binary-format": "mach-o",
+ "crt-objects-fallback": "false",
Review Comment:
Is your intention the same as the patch below?
Also, should I move `tools/aarch64-unknown-nuttx.json` to the nuttx git as
well?
```diff
diff --git a/cmake/nuttx_add_rust.cmake b/cmake/nuttx_add_rust.cmake
index dfa91c31c..2c28983f0 100644
--- a/cmake/nuttx_add_rust.cmake
+++ b/cmake/nuttx_add_rust.cmake
@@ -57,7 +57,8 @@ function(nuttx_rust_target_triple ARCHTYPE ABITYPE CPUTYPE
OUTPUT)
set(TARGET_TRIPLE "${APPDIR}/tools/i486-unknown-nuttx.json")
elseif(ARCHTYPE STREQUAL "aarch64")
if(CONFIG_ARCH_SIM AND CONFIG_HOST_MACOS)
- set(TARGET_TRIPLE "${APPDIR}/tools/aarch64-unknown-nuttx-macho.json")
+ set(TARGET_TRIPLE
+ "${PROJECT_SOURCE_DIR}/tools/aarch64-unknown-nuttx-macho.json")
else()
set(TARGET_TRIPLE "${APPDIR}/tools/aarch64-unknown-nuttx.json")
endif()
diff --git a/tools/Rust.mk b/tools/Rust.mk
index 9ca03bdac..4fc74af4e 100644
--- a/tools/Rust.mk
+++ b/tools/Rust.mk
@@ -56,7 +56,7 @@ $(or \
), \
$(and $(filter aarch64,$(LLVM_ARCHTYPE)), \
$(if $(and $(filter sim,$(CONFIG_ARCH)),$(filter
y,$(CONFIG_HOST_MACOS))), \
- $(APPDIR)/tools/aarch64-unknown-nuttx-macho.json, \
+ $(TOPDIR)/tools/aarch64-unknown-nuttx-macho.json, \
$(APPDIR)/tools/aarch64-unknown-nuttx.json \
) \
), \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
