xiaoxiang781216 commented on a change in pull request #1703:
URL: https://github.com/apache/incubator-nuttx/pull/1703#discussion_r483611273
##########
File path: arch/sim/include/irq.h
##########
@@ -108,9 +112,6 @@ extern "C"
irqstate_t up_irq_save(void);
void up_irq_restore(irqstate_t flags);
-#undef EXTERN
Review comment:
mismatch with line 95-101
##########
File path: arch/sim/include/irq.h
##########
@@ -76,11 +76,15 @@ typedef int xcpt_reg_t;
struct xcptcontext
{
- void *sigdeliver; /* Actual type is sig_deliver_t */
Review comment:
should we keep this comment?
##########
File path: arch/sim/src/Makefile
##########
@@ -97,6 +97,14 @@ ifeq ($(CONFIG_SPINLOCK),y)
HOSTSRCS += up_testset.c
endif
+ifeq ($(CONFIG_SIM_UCONTEXT_PREEMPTION),y)
+ HOSTSRCS += up_ucontext.c
+ifeq ($(CONFIG_HOST_MACOS), y)
+ HOSTCFLAGS += -Wno-deprecated-declarations
Review comment:
no needed, add at line 83
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
