hartmannathan commented on PR #19143: URL: https://github.com/apache/nuttx/pull/19143#issuecomment-4708018436
> @michallenc has objections to move common code to `arch/arm/src/common/stm32` in https://github.com/apache/nuttx/pull/19004#issuecomment-4599658208 and I understand it, but I don't see any other option to solve this problem. The alternative is either to leave `arch/stm32` and `arch/stm32f0l0g0` (problem not solved), or to duplicate the code for all families (even bigger problem). > > > > Yet another option might be to change common sources from `arch/arm/src/common/stm32` to `arch/arm/src/st` or `arch/arm/src/stm32`, but the current path follows another example of common sources in arch: `arch/risc-v/src/common/espressif`. I prefer consistency as much as possible throughout the NuttX tree. Once someone becomes familiar with using NuttX on one architecture, it is beneficial if other architectures follow similar patterns. arch/arm/src/common/stm32 is a parallel of arch/risc-v/src/common/espressif, so that would give us two architectures following a similar pattern. Hopefully other architectures are consistent with this layout too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
