tmedicci commented on code in PR #3540:
URL: https://github.com/apache/nuttx-apps/pull/3540#discussion_r3415035469


##########
netutils/libwebsockets/CMakeLists.txt:
##########
@@ -178,7 +187,8 @@ if(CONFIG_NETUTILS_LIBWEBSOCKETS)
   set_property(
     TARGET nuttx
     APPEND
-    PROPERTY NUTTX_INCLUDE_DIRECTORIES ${LIBWEBSOCKETS_DIR}/include)
+    PROPERTY NUTTX_INCLUDE_DIRECTORIES ${LIBWEBSOCKETS_DIR}/include
+                                       ${CMAKE_CURRENT_LIST_DIR})

Review Comment:
   `LIBWEBSOCKETS_DIR` refers to 
`apps/netutils/libwebsockets/libwebsockets/include`. This is libwesocket's 
public header include path.
   
   So far, no other applications on NuttX included 
`apps/netutils/libwebsockets/libwebsockets/include/libwebsockets.h` and this 
file includes `lws_config.h`. That's why we need to include 
`${CMAKE_CURRENT_LIST_DIR}` too. In this case, the example application 
(`lws_echo`) includes `libwebsockets.h`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to