acassis commented on code in PR #3542:
URL: https://github.com/apache/nuttx-apps/pull/3542#discussion_r3422069783


##########
interpreters/python/Makefile:
##########
@@ -163,7 +163,7 @@ $(TARGETBUILD)/Makefile: $(HOSTPYTHON) $(CONFIG_SITE) 
$(SETUP_LOCAL)
                        AR="$(AR)" \
                        ARFLAGS=" " \
                        MACHDEP="$(MACHDEP)" \
-                       OPT="-O3" \
+                       OPT="-Os" \

Review Comment:
   @tmedicci @xiaoxiang781216 I think the optimization flags should come from 
NuttX building system, because it was common in the past have some 
optimizations which crash the final firmware for some compilers, so fixing this 
OPT could cause that issue on some arch. But the idea of reducing size is very 
good, but it could come from defconfig



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to