arjav1528 commented on PR #18828:
URL: https://github.com/apache/nuttx/pull/18828#issuecomment-4736066298

   @maxikrie
   btw while fixing the build break I found the gap goes deeper than the 
compiler-prefix issue
   what I have fixed : arch/xtensa/src/cmake/Toolchain.cmake had a stray 
trailing dash in TOOLCHAIN_PREFIX producing xtensa-esp32-elf--gcc. it now 
matches arm/risc-v/tricore.
   
   what I found while fixing:  hal_esp32{s2,s3}.cmake are never included, 
xtensa/src/common/espressif/CMakeLists.txt is missing the plumbing the risc-v 
equivalent has (esp_hal_3rdparty_reepo FetchContent, CHIP_SERIES, 
include(hal_${CHIP_SERIES}.cmake), HAL include dirs, header copy, startup -u 
flags). the configure fails before even reaching HAL sources.
   
   I am thinking of moving this to draft, and then porting the missing common 
cmake from risc-v, then validating localy wiht the toolchain, and then open 
this for review, and then ask you for HW runtime, should I implement that??
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to