mkj commented on code in PR #3532: URL: https://github.com/apache/nuttx-apps/pull/3532#discussion_r3464669844
########## netutils/dropbear/dropbear_main.c: ########## @@ -0,0 +1,305 @@ +/**************************************************************************** + * apps/netutils/dropbear/dropbear_main.c + * + * SPDX-License-Identifier: Apache-2.0 + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <sys/socket.h> +#include <setjmp.h> +#include <stdarg.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> + +#include "includes.h" +#include "algo.h" +#include "crypto_desc.h" +#define dropbear_main dropbear_multi_entry +#include "dbutil.h" +#undef dropbear_main Review Comment: I think it's better to keep a patch in nuttx. `-Dmain` is pretty unusual. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
