linguini1 commented on code in PR #3573: URL: https://github.com/apache/nuttx-apps/pull/3573#discussion_r3499686676
########## games/NXDoom/.devcontainer/.gitignore: ########## @@ -1,4 +0,0 @@ -*.xauth Review Comment: No because it is super time consuming already to modify all the source files to pass CI. Most of what I removed is not intended to be supported as part of the DOOM port (i.e., Hexen, Strife, etc.). In the future, if someone would like to bring in support for those other things, it should be quite easy to cherry pick the appropriate files from the Chocolate DOOM repo and modify them. Otherwise they just sit uncompiled but I have to modify them all to pass CI checks. EDIT: also, a lot of what I removed I have no way to test (like the various sound libraries for different platforms) and are highly likely to not ever be compatible with NuttX. I want a minimal port here :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
