speccy88 opened a new pull request, #3578:
URL: https://github.com/apache/nuttx-apps/pull/3578
## Summary
This fixes the current `sim:berry` Linux CI failure seen from
`apache/nuttx#19224` after the CRLF patch fix was merged.
The pinned Berry source compiles with two `-Wshadow` diagnostics in:
- `src/be_introspectlib.c`
- `src/be_module.c`
NuttX CI builds `sim:berry` with `-Werror`, so those diagnostics fail the
build. I added a second local Berry patch that only renames the shadowing local
variables, without changing behavior, and apply it in both the Make and CMake
fetch paths.
## Verification
I verified the patch applies cleanly to the exact pinned Berry ZIP payload
after the existing NuttX patch.
I also ran the targeted failing config in the Apache Linux CI container
against `apache/nuttx#19224` head plus this apps commit:
```sh
./tools/testbuild.sh -l -C -x -j $(nproc) -a ../apps \
-t /github/workspace/sources/nuttx \
-e '-Wno-cpp -Werror' -S /github/workspace/sim-berry-make.dat
```
Result: `sim:berry` Make build passed.
I also tested the CMake/Ninja path:
```sh
./tools/testbuild.sh -l -C -x -N -j $(nproc) -a ../apps \
-t /github/workspace/sources/nuttx \
-e '-Wno-cpp -Werror' -S /github/workspace/sim-berry-cmake.dat
```
Result: `sim:berry` CMake/Ninja build passed.
Local checks:
```sh
git diff --check origin/master..HEAD
/tmp/nuttx-pr19224/tools/checkpatch.sh -c -u -m -g origin/master..HEAD
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
