speccy88 commented on PR #19224: URL: https://github.com/apache/nuttx/pull/19224#issuecomment-4856456931
I checked Build #55511. The current failure is no longer the CRLF patch application problem; that fix is already merged in `apache/nuttx-apps`. The remaining `Linux (sim-01)` failure is from Berry source compiling with `-Werror`: ``` berry/src/be_introspectlib.c:137:25: error: declaration of 'top' shadows a previous local [-Werror=shadow] berry/src/be_module.c:380:17: error: declaration of 'type' shadows a previous local [-Werror=shadow] ``` I opened the apps-side fix here: https://github.com/apache/nuttx-apps/pull/3578 That PR patches the pinned Berry source to rename the two shadowing locals and applies the patch in both Make and CMake fetch paths. I verified it locally in the Apache Linux CI container against this NuttX PR head plus the apps fix: ``` ./tools/testbuild.sh -l -C -x -j $(nproc) -a ../apps \ -t /github/workspace/sources/nuttx \ -e '-Wno-cpp -Werror' -S /github/workspace/sim-berry-make.dat ./tools/testbuild.sh -l -C -x -N -j $(nproc) -a ../apps \ -t /github/workspace/sources/nuttx \ -e '-Wno-cpp -Werror' -S /github/workspace/sim-berry-cmake.dat ``` Both targeted `sim:berry` builds passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
