xiaoxiang781216 commented on code in PR #19259:
URL: https://github.com/apache/nuttx/pull/19259#discussion_r3510010921
##########
arch/sim/src/sim/posix/sim_hostfs.c:
##########
@@ -124,6 +124,30 @@ static void host_stat_convert(struct stat *hostbuf, struct
nuttx_stat_s *buf)
* Public Functions
****************************************************************************/
+/****************************************************************************
+ * Name: host_stdio_nonblock
+ ****************************************************************************/
+
+void host_stdio_nonblock(void)
Review Comment:
why not modify sim_hostuart.c
##########
arch/sim/src/sim/sim_head.c:
##########
@@ -170,6 +170,10 @@ int main(int argc, char **argv, char **envp)
g_argc = argc;
g_argv = argv;
+#ifndef CONFIG_WINDOWS_NATIVE
Review Comment:
remove
##########
arch/sim/src/sim/sim_internal.h:
##########
@@ -225,6 +225,9 @@ pid_t host_posix_spawn(const char *path,
char *const argv[], char *const envp[]);
int host_waitpid(pid_t pid);
int host_kill(pid_t pid, int sig);
+#ifndef CONFIG_WINDOWS_NATIVE
Review Comment:
remove, Windows support the nonblocking mode, either add a full or dummy
implementation on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
