linguini1 opened a new pull request, #19307:
URL: https://github.com/apache/nuttx/pull/19307

   ## Summary
   
   All I2S driver operation functions say in their signature description that 
negative errno values are returned on failure. However, some of these same 
functions had `uint32_t` return types. This would result in incorrect 
comparison of the return value against signed error code values.
   
   Closes #19293.
   
   ## Impact
   
   Fixes I2S driver signatures for correct comparisons, touches multiple
   architecture's I2S drivers. Reduces the maximum positive return value that 
these
   functions can return (i.e. under 2GHz for mclk).
   
   ## Testing
   
   CI build test to verify no compilation errors. I cannot test the results on 
the modified targets, however I am not aware that any of these driver 
implementations used the full width of the uint32_t return type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to