cederom commented on code in PR #18837:
URL: https://github.com/apache/nuttx/pull/18837#discussion_r3528180899
##########
arch/arm/src/cxd32xx/cxd32_serial_pl011.c:
##########
@@ -59,7 +59,7 @@ void arm_earlyserialinit(void)
* when they are first opened.
*/
- pl011_earlyserialinit();
+ #error "Not implemented"
Review Comment:
Do we want here something like:
```
#ifdef CONSOLE_DEV
pl011_dev_init(&CONSOLE_DEV);
CONSOLE_DEV.uart.isconsole = true;
CONSOLE_DEV.uart.ops->setup(&CONSOLE_DEV.uart); /* Early set up */
#endif
```
and in other similar places where `#error "Not implemented"` shows up?
Or this setup is provided by the arch below and not necessary here anymore?
If so do we want error here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
