ricardgb commented on PR #19255: URL: https://github.com/apache/nuttx/pull/19255#issuecomment-4895669866
> > @ricardgb I am doubting this is the correct way to setup the mtd on flash for the rp2350. Normally I would expect the mtd to be setup for the whole flash and then to do some partitioning on top of that, not set it up for only a part. If you later want to do some firmware upgrade you also want to have the nuttx part avalable (at e.g. /ota0). Also I think you should always specify the length of the data partition. > > So I think there should be 2 parts in the config: 1. Enable mtd_flash support, 2. Enable a mtd_flash data partition (depending on mtd_flash support) with specified mountpoint, offset and size. > > You're right — this should be a whole-flash MTD with mtd_partition() on top, not a pre-offset partial device, so the NuttX/OTA region stays addressable (e.g. /dev/rpflash, /ota0). I'll restructure the Kconfig into (1) enable flash MTD, (2) a data partition depending on it with explicit mountpoint/offset/size, refactor the driver to be offset-agnostic, and carve the data region with mtd_partition() in bringup. Thanks for the review. This is now done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
