Abhishekmishra2808 commented on code in PR #19321:
URL: https://github.com/apache/nuttx/pull/19321#discussion_r3535107859
##########
cmake/nuttx_add_romfs.cmake:
##########
@@ -284,12 +284,39 @@ function(process_all_directory_romfs)
# Auto-generate /etc/passwd at build time if configured
if(CONFIG_BOARD_ETC_ROMFS_PASSWD_ENABLE)
+ execute_process(COMMAND "${NUTTX_DIR}/tools/apply_romfs_credentials.sh"
+ "${NUTTX_DIR}/.config" RESULT_VARIABLE _cred_rc)
+ if(NOT _cred_rc EQUAL 0)
+ message(FATAL_ERROR "apply_romfs_credentials.sh failed (rc=${_cred_rc})")
+ endif()
Review Comment:
Addressed in 2a91975d58: scripts are invoked via find_program(sh bash) +
${NUTTX_POSIX_SHELL} instead of executing the .sh path directly. The block is
only active for CONFIG_BOARD_ETC_ROMFS_PASSWD_ENABLE=y (sim:login). Please
check it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
