hitHuang opened a new pull request, #3635:
URL: https://github.com/apache/nuttx-apps/pull/3635

   ## Summary
   
   Companion to apache/nuttx#<TODO-PR-NUMBER>, which splits the compile-time
   name/priority/stacksize registry table (`struct builtin_s` / `g_builtins[]`) 
out of
   `CONFIG_BUILTIN` into a new hidden symbol, `CONFIG_APP_REGISTRY`
   (`default y if BUILTIN || BUILD_KERNEL`).
   
   This PR switches `builtin/Make.defs` and `nshlib/nsh_fileapps.c` from 
`CONFIG_BUILTIN` to
   `CONFIG_APP_REGISTRY`, so `nsh_fileapp()` can apply an app's configured 
priority/stacksize
   via `posix_spawn()` under `CONFIG_BUILD_KERNEL`. `exec_builtin.c` stays on 
`CONFIG_BUILTIN`.
   
   **Must be merged after apache/nuttx#<TODO-PR-NUMBER>** — 
`CONFIG_APP_REGISTRY` doesn't
   exist on `nuttx` `master` yet; merging this first would drop `apps/builtin` 
out of the
   build even for existing `CONFIG_BUILTIN=y` configs.
   
   ## Testing
   
   See [NuttX#19412](https://github.com/apache/nuttx/pull/19412) for full 
before/after logs (`rv-virt`, `knsh_romfs`,
   modified `examples/hello`). Also re-verified `rv-virt:nsh` 
(`CONFIG_BUILTIN=y`, no
   `CONFIG_BUILD_KERNEL`) is unaffected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to