speccy88 commented on PR #3632: URL: https://github.com/apache/nuttx-apps/pull/3632#issuecomment-4953171319
Thanks for questioning the scope of this change. I retraced the reproducer and found that the behavior was real in my downstream Fruit Jam image, but the root cause was in that integration rather than in Berry or stock NuttX. My downstream NSH console patch configured the shared USB CDC descriptor with `c_iflag = 0` and `c_lflag = ISIG` so readline could own input and echo permanently. Berry then inherited the same raw descriptor, without canonical buffering or CR-to-LF translation, and its normal `fgets()` input appeared to hang. I have corrected the terminal lifecycle at the point where I introduced the regression in [speccy88/NuttX-RP2350#4](https://github.com/speccy88/NuttX-RP2350/pull/4): the terminal remains canonical and echo-enabled for applications, while NSH readline temporarily takes byte-at-a-time/no-driver-echo ownership and restores the complete saved mode before launching a command. The Berry-specific reader has been removed downstream. This PR is therefore not pertinent to NuttX Apps, and I am closing it. Thank you for catching the scope problem before merge. For transparency, Codex (GPT-5) assisted with diagnosis, implementation, and review. I reviewed the result and remain responsible for the contribution. Future AI-assisted Apache commits from me will include the required `Assisted-by: Codex:GPT-5` trailer alongside my own human sign-off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
