hitHuang commented on code in PR #19412:
URL: https://github.com/apache/nuttx/pull/19412#discussion_r3567538310
##########
libs/libc/builtin/Kconfig:
##########
@@ -13,3 +13,15 @@ config BUILTIN
those names in a file system from which they can be executed.
This feature
is also the underlying requirement to support built-in
applications in the
NuttShell (NSH).
+
+config APP_REGISTRY
+ bool
+ default y if BUILTIN || BUILD_KERNEL
Review Comment:
Thanks for the suggestion. We went with the registry-table approach because
it keeps priority/stacksize as external launch policy — decided by whatever
does the spawning (`nsh_fileapp()`) — rather than something the application
binary declares about itself. It also reuses the existing `struct builtin_s`
table and `Application.mk` registration path that `CONFIG_BUILTIN` already
populates for FLAT/PROTECTED builds, so the change stays minimal.
Could you expand a bit on the ELF symbol idea — e.g. where exactly the value
would be attached (a plain symbol the loader looks up by a fixed name, vs. a
dedicated section), and whether it's meant to replace `APP_REGISTRY` outright
or complement it? That'll help us evaluate it against the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
