Zepp-Hanzj commented on code in PR #3639:
URL: https://github.com/apache/nuttx-apps/pull/3639#discussion_r3594764822


##########
testing/drivers/drivertest/Kconfig:
##########
@@ -24,6 +24,14 @@ config TESTING_DRIVER_TEST_SIMPLE
        bool "Enable cmocka driver simple test"
        default n
 
+config TESTING_DRIVER_TEST_WATCHDOG_ONLY

Review Comment:
   This option was originally added to isolate the notifier tests on the 
simulator, because the existing watchdog tests require reset-cause support and 
a real watchdog device. After re-evaluating the registration logic, I agree 
that a special WATCHDOG_ONLY option is unnecessary and causes the existing 
watchdog tests to be skipped.  
   I will remove it, register cmocka_driver_watchdog when either 
CONFIG_BOARDCTL_RESET_CAUSE or CONFIG_WATCHDOG_TIMEOUT_NOTIFIER is available, 
and guard the hardware and notifier test groups separately. This preserves all 
existing watchdog tests when reset-cause support is available, while the 
simulator runs only the notifier cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to