ricardgb commented on PR #19452: URL: https://github.com/apache/nuttx/pull/19452#issuecomment-5066215436
@xiaoxiang781216 you're right, that one was mine — thanks. `ARCH_USBDEV_STALLQUEUE` depends on `USBDEV`, so the unconditional chip-level `select` tripped a Kconfig dependency warning (fatal in CI) on every rp2040/rp23xx config built without USB device support, e.g. `seeed-xiao-rp2040/nsh`: ``` warning: ARCH_USBDEV_STALLQUEUE ... has direct dependencies USBDEV with value n, but is currently being y-selected by ARCH_CHIP_RP2040 ``` Fixed by making it `select ARCH_USBDEV_STALLQUEUE if USBDEV` for both chips, which matches the symbol's dependency and the condition under which the USB driver is even compiled (`Make.defs` guards `rp2040_usbdev.c`/`rp23xx_usbdev.c` with `CONFIG_USBDEV`). Verified locally: `olddefconfig` is warning-free for `raspberrypi-pico:nsh` (USBDEV=n, symbol stays off) and `raspberrypi-pico:usbnsh` / `raspberrypi-pico-2:usbnsh` (USBDEV=y, symbol on), and the usbnsh build compiles clean with the stall queue enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
